Add isValid field to standard model validationResult #51310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't change much except aggregates the validation results into a neat field, to help us easier access this value when we update the standard model in the StandardEditor
avatus
added
the
no-changelog
rudream
approved these changes
Jan 22, 2025
kimlisa
approved these changes
Jan 22, 2025
public-teleport-github-review-bot
bot
removed the request for review
from bl-nero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change much except aggregates the validation results into a neat field, to help us easier access this value when we update the standard model in the StandardEditor.
This supports an upcoming PR to fetch diffs from access graph based on when the editor is in a "valid" state (not the UI validation, but before that happens)